Fix PHP 7.4 support for 1.x #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Is this a Travis issue or a problem with Ubuntu´s version? |
|
I haven't inspected what's going wrong with the failing travisci jobs. |
|
Yes, did it. Same error, a missing global var. Will take a look later. |
|
What about #207 ? |
|
It passes. A substantial config change was need as I see. I´ll take a look to scrutinizer. Should I close this one and we continue in #207 ? |
|
Merged #207 so you now can update. |
mlocati
force-pushed
the
fix-php7.4-support-1.x
branch
from
b46675f
to
6c9f1a0
Compare
|
PR rebased. BTW it seems that TravisCI is still having connectivity issues. @egulias could you try to restart the failing TravisCI jobs? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #203 to 1.x