Adding documentation and consolidating some code for readability #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * RFC-6530: Overview and Framework for Internationalized Email | ||
| * RFC-1123 section 2.1: Requirements for Internet Hosts -- Application and Support | ||
| * RFC-4291 section 2.2: IP Version 6 Addressing Architecture | ||
| * |
There was a problem hiding this comment.
Okay, will do. In my mind, I had been treating 6530 as the 'parent' to 6531 and 6532, but I suppose that's not really a fair way of looking at those RFCs!
|
Thanks @natechicago |
natechicago
force-pushed
the
minor-edits
branch
from
1bad852
to
58e44fb
Compare
egulias
added a commit
that referenced
this pull request
Mar 22, 2016
Adding documentation and consolidating some code for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added documentation to this class to make it easier for others to understand (at a quick glance) --
Additionally, some simple refactorings were applied to make a few parts of the code quicker/easier to read. They're logically equivalent to the original code, and the tests still pass.