translate-c: coerce boolean results to c_int when negated

Fixes ziglang#10175
ehaas · Nov 21, 2021 · c7db34f · c7db34f
1 parent a699d67
commit c7db34f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/translate_c.zig b/src/translate_c.zig
@@ -3648,7 +3648,13 @@ fn transUnaryOperator(c: *Context, scope: *Scope, stmt: *const clang.UnaryOperat
         .Plus => return transExpr(c, scope, op_expr, used),
         .Minus => {
             if (!qualTypeHasWrappingOverflow(op_expr.getType())) {
-                return Tag.negate.create(c.arena, try transExpr(c, scope, op_expr, .used));
+                const sub_expr_node = try transExpr(c, scope, op_expr, .used);
+                const to_negate = if (isBoolRes(sub_expr_node)) blk: {
+                    const ty_node = try Tag.type.create(c.arena, "c_int");
+                    const int_node = try Tag.bool_to_int.create(c.arena, sub_expr_node);
+                    break :blk try Tag.as.create(c.arena, .{ .lhs = ty_node, .rhs = int_node });
+                } else sub_expr_node;
+                return Tag.negate.create(c.arena, to_negate);
             } else if (cIsUnsignedInteger(op_expr.getType())) {
                 // use -% x for unsigned integers
                 return Tag.negate_wrap.create(c.arena, try transExpr(c, scope, op_expr, .used));

diff --git a/test/run_translated_c.zig b/test/run_translated_c.zig
@@ -1796,4 +1796,17 @@ pub fn addCases(cases: *tests.RunTranslatedCContext) void {
         \\    return 0;
         \\}
     , "");
+
+    cases.add("Boolean expression coerced to int. Issue #10175",
+        \\#include <stdlib.h>
+        \\int sign(int v) {
+        \\    return -(v < 0);
+        \\}
+        \\int main(void) {
+        \\    if (sign(-5) != -1) abort();
+        \\    if (sign(5) != 0) abort();
+        \\    if (sign(0) != 0) abort();
+        \\    return 0;
+        \\}
+    , "");
 }