Issue 101 #152
Issue 101 #152
Conversation
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
|
test this please |
|
Test FAILed. |
|
No idea what's wrong! I'll let smart people tell me what I've done wrong... |
|
what didn't you change? :-) |
|
Most likely xjc failing due to spaces in the path ... |
|
So @ljacomet ... no solution? Is it the plugin's fault or xic's? |
|
@timeck Wanted to make sure this PR stays out for review at least a month! Thought that touching as many files as possible, preferably around generics, would help ;-) |
|
Test FAILed. |
|
Expiry is still missing in the XML stuff... Realized that on the plane while doing the doc stuff. I'll address this somehow, sometime, ... |
|
So the issue with jaxb/xjc comes from the gradle plugin - I opened issue scubacabra/gradle-jaxb-plugin#16 |
| jaxb { | ||
| xsdDir = "xml/src/main/resources" | ||
| episodesDir = "$buildDir/xsd/episodes" | ||
| bindingsDir = "$buildDir/xsd/bindings" |
There was a problem hiding this comment.
Both dirs above are blindly appended to the project.rootDir, so they should be relative to it.
In this case, the value xml/build shoud replace the $buildDir variable.
|
Had a look over things here, nothing jumps out at me. Although I admit when I try to hook up 107 I might read a little more closely :-) How does one configure the expiration settings for a Cache? Or is that what you were mentioning that isn't done yet? |
|
Y forgot to wire the expiry in the config. Will try to address this ASAP, based on my availability here. |
| @@ -21,7 +21,15 @@ | |||
| <xs:complexType name="config-type"> | |||
| <xs:sequence> | |||
| <xs:element name="service" type="ehcache:service-type" minOccurs="0" maxOccurs="unbounded"/> | |||
There was a problem hiding this comment.
Is an empty configuration file legal? Both the "service" element and the wrapper around the "cache" & "cache-template" elements have a minOccurs of zero. (Appears to be existing behavior in any case.)
There was a problem hiding this comment.
I think we might want an empty config to be valid. I currently have the 107 wrapper loading an ehcache-failsafe.xml resource when creating a 107 CacheManager and not providing a config URI
|
I put a couple of really minor comments in... I can't speak for the jaxb usage, and how canonical it is though. |
|
PR #161 includes these changes it seems - asked for clarification there. |
| } | ||
|
|
||
| public static CacheManager newCacheManager(final Configuration configuration) { | ||
| return new EhcacheManager(configuration); |
There was a problem hiding this comment.
The newCacheManager(ServiceLocator, Configuration) method calls init() on the CacheManager before returning. Should init() be called here as well?
Shouldn't be too off...
For @timeck the
ParsesConfigExtensionTestclass contains my take on how to make this all work within ourjavax.cache.CacheManagerimplementation...