Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing referenced Policy Sets #22

Closed
qligier opened this issue Aug 25, 2023 · 10 comments
Closed

Missing referenced Policy Sets #22

qligier opened this issue Aug 25, 2023 · 10 comments
Labels
Ballot2023 Improvements or additions to documentation

Comments

@qligier
Copy link

qligier commented Aug 25, 2023

In PPQm Referenced Policy Set, two Policy Sets are missing: urn:e-health-suisse:2015:policies:policy-bootstrap and urn:e-health-suisse:2015:policies:doc-admin.
Are they forbidden here, or were they forgotten ?
If forbidden, a short explanation would be useful.

@unixoid
Copy link
Collaborator

unixoid commented Aug 25, 2023

Nothing is forgotten :-)
These policy sets are never referenced from templates, see Section 2 in https://github.com/ehealthsuisse/ch-epr-adr-ppq/blob/main/docs/Policies.md.

@qligier
Copy link
Author

qligier commented Aug 25, 2023

Is it only in the schema, where policy sets 1-9 are shown? In 2.2, they are described like the 9 others.

@unixoid
Copy link
Collaborator

unixoid commented Aug 25, 2023

The picture https://github.com/ehealthsuisse/ch-epr-adr-ppq/raw/main/docs/policies.png shows, which base policy sets (on the magenta background) may be referenced from policy set templates (on the yellow background). As you see, doc-admin and policy-bootstrap are not among them. As the CH:PPQm profile covers only policy sets created from the templates, it completely ignores the existence of doc-admin and policy-bootstrap.

If, at some point, the coding system PpqmReferencedPolicySet will lose the prefix Ppqm in its name and be moved from the CH:PPQm IG to the CH:EPR-Term IG, then yes, it will have to include all references. But not yet.

@qligier
Copy link
Author

qligier commented Aug 25, 2023

If, at some point, the coding system PpqmReferencedPolicySet will lose the prefix Ppqm in its name and be moved from the CH:PPQm IG to the CH:EPR-Term IG, then yes, it will have to include all references. But not yet.

In that case, you would still need a PpqmReferencedPolicySet value set. It makes sense not to have the two special elements here, I only wish a note explaining the value set does not contain the admin policy sets because they are not actionable, and thus forbidden in these exchanges.

@unixoid
Copy link
Collaborator

unixoid commented Aug 25, 2023

Ok, I will add such comment.

@unixoid
Copy link
Collaborator

unixoid commented Aug 25, 2023

And, BTW, I will not still need this value set. Actually, neither do I need it now. This is because of the ch-epr-ppqm-template-structure validation constraint in PpqmConsent.

@qligier
Copy link
Author

qligier commented Aug 25, 2023

It is also used as binding on Consent.policyRule.coding.

(Typo in ch-epr-ppqm-template-structure: correspong -> correspond)

@unixoid
Copy link
Collaborator

unixoid commented Aug 25, 2023

This is what I mean, this binding is not necessary as its effect is duplicated in the validation constraint. But I will keep it nevertheless.

(Thanks.)

@qligier
Copy link
Author

qligier commented Aug 25, 2023

Okay, I understand now, thanks!

@unixoid unixoid added the Ballot2023 Improvements or additions to documentation label Aug 30, 2023
@dkotlaris
Copy link
Contributor

26.10.2023: Accepted.

unixoid pushed a commit that referenced this issue Oct 27, 2023
@unixoid unixoid closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ballot2023 Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants