Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include conftest.py in the source distribution #15

Merged
merged 1 commit into from Oct 20, 2020

Conversation

candrews
Copy link
Contributor

Without conftest.py, pytest fails to run tests because it cannot find the dummy_onionrouter fixture:

_____________________________________________________________________________________ ERROR at setup of TestOnionRouter.test_multiple_hostnames_support ______________________________________________________________________________________
file tests/test_onionrouter.py, line 16
      def test_multiple_hostnames_support(self, dummy_onionrouter):
E       fixture 'dummy_onionrouter' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

Without conftest.py, pytest fails to run tests because it cannot find the `dummy_onionrouter` fixture:

```
_____________________________________________________________________________________ ERROR at setup of TestOnionRouter.test_multiple_hostnames_support ______________________________________________________________________________________
file tests/test_onionrouter.py, line 16
      def test_multiple_hostnames_support(self, dummy_onionrouter):
E       fixture 'dummy_onionrouter' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
```
@ioparaskev ioparaskev merged commit 8c28ab5 into ehloonion:master Oct 20, 2020
@candrews
Copy link
Contributor Author

Could please add the hacktoberfest-accepted tag to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants