Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm versions #9

Merged
merged 9 commits into from
Jun 26, 2022
Merged

Add npm versions #9

merged 9 commits into from
Jun 26, 2022

Conversation

Maxim-Mazurok
Copy link
Contributor

Which problem is this pull request solving?

Adds npm versions

List other issues or pull requests related to this problem

Closes #8

Describe the solution you've chosen

Added new "nodeNpmVersion" property to return object

Describe alternatives you've considered

Returning an array of npm versions and user would have to get index of node version, then check npm array for the same index, seems not very user friendly

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • I have added tests (we are enforcing 100% test coverage).
  • I have added documentation in the README.md, the docs directory (if
    any) and the examples directory (if any).
  • The status checks are successful (continuous integration). Those can be
    seen below.

src/normalize.js Outdated Show resolved Hide resolved
test/main.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #9 (22b88aa) into main (ad48123) will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/normalize.js 100.00% <100.00%> (ø)
Flag Coverage Δ
linux 100.00% <100.00%> (ø)
mac 100.00% <100.00%> (ø)
node_v14_18_0 100.00% <100.00%> (ø)
node_v18_4_0 100.00% <100.00%> (ø)
windows 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ehmicky
Copy link
Owner

ehmicky commented Jun 24, 2022

Thanks a lot for this PR @Maxim-Mazurok! 🎉
I added two suggestions, please let me know what you think.

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/main.d.ts Show resolved Hide resolved
src/main.d.ts Outdated Show resolved Hide resolved
src/main.d.ts Show resolved Hide resolved
@ehmicky
Copy link
Owner

ehmicky commented Jun 26, 2022

Thanks a lot @Maxim-Mazurok, great contribution! 🎉

@ehmicky ehmicky merged commit 81e76fc into ehmicky:main Jun 26, 2022
@ehmicky
Copy link
Owner

ehmicky commented Jun 26, 2022

Released in 11.0.0.

@Maxim-Mazurok
Copy link
Contributor Author

Thank you for your prompt responses, it was a pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default npm versions
2 participants