Fix Object.create(null) testing

ehmicky · May 18, 2019 · ee5b3dd · ee5b3dd
1 parent 5d046cf
commit ee5b3dd
Show file tree

Hide file tree

Showing 4 changed files with 80 additions and 5 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -13,6 +13,7 @@ export const isPlainObject = function(val) {
   return (
     typeof val === 'object' &&
     val !== null &&
+    // istanbul ignore next
     (val.constructor === Object || val.constructor === undefined)
   )
 }

diff --git a/test/options.js b/test/options.js
@@ -42,9 +42,6 @@ testEach(
       snapshotTest({ t, methodProps, data })),
 )
 
-testEach(
-  METHODS,
-  [{}, { opts: Object.create(null) }],
-  (suffix, methodProps, data) =>
-    test(`No options ${suffix}`, t => snapshotTest({ t, methodProps, data })),
+testEach(METHODS, [{}, { opts: {} }], (suffix, methodProps, data) =>
+  test(`No options ${suffix}`, t => snapshotTest({ t, methodProps, data })),
 )
diff --git a/test/snapshots/options.js.md b/test/snapshots/options.js.md
@@ -2915,3 +2915,80 @@ Generated by [AVA](https://ava.li).
       test␊
       [12:00:00] Finished 'main' after 100 ms`,
     }
+
+## No options | exec { opts: {} }
+
+> Snapshot 1
+
+    {
+      exitCode: 0,
+      stderr: '',
+      stdout: `[12:00:00] Starting 'main'...␊
+      [12:00:00] [gulp-execa] echo test␊
+      test␊
+      [12:00:00] Finished 'main' after 100 ms`,
+    }
+
+## No options | stream-buffer { opts: {} }
+
+> Snapshot 1
+
+    {
+      exitCode: 0,
+      stderr: '',
+      stdout: `[12:00:00] Starting 'main'...␊
+      test␊
+      ␊
+      [12:00:00] Finished 'main' after 100 ms`,
+    }
+
+## No options | stream-save { opts: {} }
+
+> Snapshot 1
+
+    {
+      exitCode: 0,
+      stderr: '',
+      stdout: `[12:00:00] Starting 'main'...␊
+      [␊
+        {␊
+          "command": "echo test",␊
+          "exitCode": 0,␊
+          "exitCodeName": "SUCCESS",␊
+          "stdout": "test",␊
+          "stderr": "",␊
+          "all": "test",␊
+          "failed": false,␊
+          "timedOut": false,␊
+          "isCanceled": false,␊
+          "killed": false␊
+        }␊
+      ]␊
+      [12:00:00] Finished 'main' after 100 ms`,
+    }
+
+## No options | stream-stream { opts: {} }
+
+> Snapshot 1
+
+    {
+      exitCode: 0,
+      stderr: '',
+      stdout: `[12:00:00] Starting 'main'...␊
+      test␊
+      ␊
+      [12:00:00] Finished 'main' after 100 ms`,
+    }
+
+## No options | task { opts: {} }
+
+> Snapshot 1
+
+    {
+      exitCode: 0,
+      stderr: '',
+      stdout: `[12:00:00] Starting 'main'...␊
+      [12:00:00] [gulp-execa] echo test␊
+      test␊
+      [12:00:00] Finished 'main' after 100 ms`,
+    }
diff --git a/test/snapshots/options.js.snap b/test/snapshots/options.js.snap