Skip to content

Commit

Permalink
Add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ehmicky committed Sep 19, 2021
1 parent c4ac635 commit 2b279ac
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/combination/filter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
import omit from 'omit.js'

// Retrieve `noDimensions`, i.e. dimensions that have the same ids across all
// combinations. Those are not reported, since they are redundant for users.
// combinations.
// Those are not reported, since they are redundant for users.
// We only filter those just before reporting|printing:
// - `noDimensions` are always kept otherwise because lots of logic relies on
// all dimensions, even redundant, to be present: select, limit,
// id validation
// - We also keep all dimensions in result files since history merging and
// `select` might add|remove redundant dimensions
// - We do filter `noDimensions` inside the `result` passed to reporters though
// - So they do not have to
// - To ensure they do not report them
export const getNoDimensions = function (combinations) {
const dimensionsArray = combinations.map(getCombinationDimensions)
return getCombNoDimensions(dimensionsArray)
Expand Down

0 comments on commit 2b279ac

Please sign in to comment.