Refactoring

ehmicky · Sep 5, 2021 · 3f8a170 · 3f8a170
1 parent 260fb3a
commit 3f8a170
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/src/report/reporters/boxplot/min_max.js b/src/report/reporters/boxplot/min_max.js
@@ -1,3 +1,5 @@
+import { isMeasuredCombination } from './normalize.js'
+
 // Return the minimum|maximum value of all combinations.
 // This is used as the extreme values of all box plots since they share the
 // same abscissa so they can be vertically compared.
@@ -17,10 +19,6 @@ export const getMinMaxAll = function (combinations) {
   return { minAll, maxAll }
 }
 
-const isMeasuredCombination = function ({ quantiles }) {
-  return quantiles !== undefined
-}
-
 const getQuantile = function ({ quantiles }, statName) {
   return quantiles[statName].raw
 }
diff --git a/src/report/reporters/boxplot/normalize.js b/src/report/reporters/boxplot/normalize.js
@@ -19,3 +19,7 @@ export const normalizeQuantiles = function ({
 
 // List of quantiles shown by the reporter
 const QUANTILES = { min: 0, q1: 25, median: 50, q3: 75, max: 100 }
+
+export const isMeasuredCombination = function ({ quantiles }) {
+  return quantiles !== undefined
+}
diff --git a/src/report/reporters/boxplot/width.js b/src/report/reporters/boxplot/width.js
@@ -1,6 +1,7 @@
 import { getCombinationPaddedName } from '../../utils/name.js'
 
 import { getPaddedStatLength } from './box.js'
+import { isMeasuredCombination } from './normalize.js'
 import { getIndex } from './position.js'
 
 // Compute the width of each column.
@@ -52,7 +53,9 @@ const getMinMaxBlockWidth = function ({
     return 0
   }
 
-  const combinationsQuantiles = getCombinationsQuantiles(combinations, statName)
+  const combinationsQuantiles = combinations
+    .filter(isMeasuredCombination)
+    .map(({ quantiles }) => quantiles[statName])
 
   if (combinationsQuantiles.length === 0) {
     return 0
@@ -87,16 +90,6 @@ const getMinMaxBlockWidth = function ({
   return minMaxWidth
 }
 
-const getCombinationsQuantiles = function (combinations, statName) {
-  return combinations
-    .filter(isMeasuredCombination)
-    .map((combination) => combination.quantiles[statName])
-}
-
-const isMeasuredCombination = function ({ quantiles }) {
-  return quantiles !== undefined
-}
-
 // Computes the minimum size for `minWidth`/`maxWidth` where a given
 // combination's `min` or `max` label does not display beyond its borders.
 const getMinMaxWidth = function ({