Refactoring

ehmicky · Dec 26, 2021 · 46e363b · 46e363b
1 parent 1f08666
commit 46e363b
Showing 1 changed file with 31 additions and 20 deletions.
diff --git a/src/system/footer/shared_2.js b/src/system/footer/shared_2.js
@@ -82,29 +82,40 @@ const reduceEachPropDimensions = function (
 
 const reduceAllPropDimensions = function (allDimensions, systems) {
   return allDimensions.reduce(
-    (allDimensionsA, dimensions, index) =>
-      Object.keys(dimensions).reduceRight((allDimensionsB, dimensionName) => {
-        const matching = systems.filter((system) =>
-          allDimensionsB.some((dimensionsB, indexB) =>
-            Object.entries(dimensionsB).every(
-              ([dimensionNameB, dimensionValueB]) =>
-                system.dimensions[dimensionNameB] === dimensionValueB ||
-                (indexB === index && dimensionNameB === dimensionName),
-            ),
+    reduceOnePropDimensions.bind(undefined, systems),
+    allDimensions,
+  )
+}
+
+const reduceOnePropDimensions = function (
+  systems,
+  allDimensionsA,
+  dimensions,
+  index,
+) {
+  return Object.keys(dimensions).reduceRight(
+    (allDimensionsB, dimensionName) => {
+      const matching = systems.filter((system) =>
+        allDimensionsB.some((dimensionsB, indexB) =>
+          Object.entries(dimensionsB).every(
+            ([dimensionNameB, dimensionValueB]) =>
+              system.dimensions[dimensionNameB] === dimensionValueB ||
+              (indexB === index && dimensionNameB === dimensionName),
           ),
-        )
+        ),
+      )
 
-        if (matching.length !== allDimensionsB.length) {
-          return allDimensionsB
-        }
+      if (matching.length !== allDimensionsB.length) {
+        return allDimensionsB
+      }
 
-        return [
-          ...allDimensionsB.slice(0, index),
-          omit.default(allDimensionsB[index], [dimensionName]),
-          ...allDimensionsB.slice(index + 1),
-        ]
-      }, allDimensionsA),
-    allDimensions,
+      return [
+        ...allDimensionsB.slice(0, index),
+        omit.default(allDimensionsB[index], [dimensionName]),
+        ...allDimensionsB.slice(index + 1),
+      ]
+    },
+    allDimensionsA,
   )
 }