Refactoring

ehmicky · Dec 12, 2021 · 6f61395 · 6f61395
1 parent 23e7747
commit 6f61395
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/stats/cold.js b/src/stats/cold.js
@@ -131,13 +131,9 @@ const findClosestMean = function (array, { mean, minIndex, maxIndex, filter }) {
   let closestMean = 0
   let closestMeanDiff = Number.POSITIVE_INFINITY
   let sum = 0
-  let index = -1
   let filteredIndex = 0
 
-  while (filteredIndex !== maxIndex) {
-    index += 1
-    const value = array[index]
-
+  for (const value of array) {
     if (!filter(value)) {
       continue
     }
@@ -149,6 +145,10 @@ const findClosestMean = function (array, { mean, minIndex, maxIndex, filter }) {
       continue
     }
 
+    if (filteredIndex === maxIndex) {
+      break
+    }
+
     const incrementalMean = sum / filteredIndex
     const meanDiff = Math.abs(mean - incrementalMean)