Refactoring

ehmicky · Nov 28, 2021 · 823853c · 823853c
1 parent 3350085
commit 823853c
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/src/stats/welch.js b/src/stats/welch.js
@@ -39,16 +39,8 @@ export const isDiffPrecise = function (
     return false
   }
 
-  const adjustedLoopsA = applyImpreciseEnvDev(
-    loopsA,
-    envDevA,
-    ENV_DEV_IMPRECISION,
-  )
-  const adjustedLoopsB = applyImpreciseEnvDev(
-    loopsB,
-    envDevB,
-    ENV_DEV_IMPRECISION,
-  )
+  const adjustedLoopsA = adjustLoops(loopsA, envDevA)
+  const adjustedLoopsB = adjustLoops(loopsB, envDevB)
   return (
     hasPreciseLoops(adjustedLoopsA, adjustedLoopsB) &&
     welchTTest({
@@ -72,6 +64,11 @@ const hasPreciseStdev = function (stdevA, stdevB) {
   )
 }
 
+// We take `envDev` into account
+const adjustLoops = function (loops, envDev) {
+  return applyImpreciseEnvDev(loops, envDev, ENV_DEV_IMPRECISION)
+}
+
 // A higher value creates more false negatives.
 // A lower value creates more false positives.
 // False positives are more disruptives to the user experience, so we prefer