Refactoring

src/config/plugin/add.js

@@ -58,5 +58,5 @@ const getPluginsByType = async function ({
     context,
     configInfos,
   })
-  return [pluginType.selectProp.name, plugins]
+  return [pluginType.name, plugins]
 }

src/config/plugin/id.js

@@ -9,10 +9,10 @@ import { PluginError } from '../../error/main.js'
 // (e.g. runners) because those should use variations instead.
 // Since the list of plugin module names is unknown, users must indicate using
 // this by the usage of a delimiter character.
-export const getModuleId = function (id, multiple, selectPropName) {
+export const getModuleId = function (id, multiple, name) {
   const [moduleId, customId] = splitId(id, multiple)
-  validateModuleId(moduleId, selectPropName)
-  validateCustomId(customId, selectPropName)
+  validateModuleId(moduleId, name)
+  validateCustomId(customId, name)
   return moduleId
 }
 
@@ -34,9 +34,9 @@ const splitId = function (id, multiple) {
 
 const CUSTOM_ID_DELIMITER = '_'
 
-const validateModuleId = function (moduleId, selectPropName) {
+const validateModuleId = function (moduleId, name) {
   if (!MODULE_ID_REGEXP.test(moduleId)) {
-    throw new PluginError(`The identifier of the ${selectPropName} "${moduleId}" is invalid.
+    throw new PluginError(`The identifier of the ${name} "${moduleId}" is invalid.
 It should only contain lowercase letters and digits.`)
   }
 }
@@ -52,11 +52,11 @@ It should only contain lowercase letters and digits.`)
 // This is purposely not applied to shared configs.
 const MODULE_ID_REGEXP = /^[a-z][a-z\d]*$/u
 
-const validateCustomId = function (customId, selectPropName) {
+const validateCustomId = function (customId, name) {
   if (customId !== undefined) {
     validateUserId({
       id: customId,
-      messageName: `${selectPropName} identifier suffix`,
+      messageName: `${name} identifier suffix`,
     })
   }
 }

src/config/plugin/import.js

@@ -11,12 +11,12 @@ import { getModuleId } from './id.js'
 // a dynamic `Module` instance.
 export const importPlugin = async function ({
   id,
-  selectPropName,
+  name,
   modulePrefix,
   builtins,
   multiple,
 }) {
-  const moduleId = getModuleId(id, multiple, selectPropName)
+  const moduleId = getModuleId(id, multiple, name)
   const builtin = builtins[moduleId]
 
   if (builtin !== undefined) {
@@ -26,7 +26,7 @@ export const importPlugin = async function ({
   const moduleName = `${modulePrefix}${moduleId}`
   const pluginPath = safeGetPluginPath({
     moduleName,
-    selectPropName,
+    name,
     base: PLUGINS_IMPORT_BASE,
   })
 
@@ -35,7 +35,7 @@ export const importPlugin = async function ({
   } catch (error) {
     throw wrapError(
       error,
-      `Could not load "${selectPropName}" module "${moduleId}"\n\n`,
+      `Could not load "${name}" module "${moduleId}"\n\n`,
       PluginError,
     )
   }
@@ -49,15 +49,11 @@ export const importPlugin = async function ({
 //  - This prevent the confusion (which could be malicious) created by the
 //    ambiguity
 // TODO: use import.meta.resolve() when available
-const safeGetPluginPath = function ({ moduleName, selectPropName, base }) {
+const safeGetPluginPath = function ({ moduleName, name, base }) {
   try {
     return getPluginPath(moduleName, base)
   } catch (error) {
-    throw wrapError(
-      error,
-      `Configuration property "${selectPropName}"`,
-      UserError,
-    )
+    throw wrapError(error, `The ${name}`, UserError)
   }
 }
 

src/config/plugin/load.js

@@ -26,7 +26,7 @@ export const loadPlugins = async function ({
 const loadPlugin = async function (
   { id, config, topConfig, context, configInfos },
   {
-    selectProp: { name: selectPropName },
+    name,
     configProp: { name: configPropName },
     modulePrefix,
     builtins,
@@ -38,7 +38,7 @@ const loadPlugin = async function (
 ) {
   const plugin = await importPlugin({
     id,
-    selectPropName,
+    name,
     modulePrefix,
     builtins,
     multiple,

src/config/plugin/types.js

@@ -3,8 +3,8 @@ import { RUNNER_PLUGIN_TYPE } from '../../runners/plugin.js'
 
 // All plugin types
 export const PLUGIN_TYPES = {
-  [RUNNER_PLUGIN_TYPE.selectProp.name]: RUNNER_PLUGIN_TYPE,
-  [REPORTER_PLUGIN_TYPE.selectProp.name]: REPORTER_PLUGIN_TYPE,
+  [RUNNER_PLUGIN_TYPE.name]: RUNNER_PLUGIN_TYPE,
+  [REPORTER_PLUGIN_TYPE.name]: REPORTER_PLUGIN_TYPE,
 }
 
 export const PLUGIN_TYPES_ARRAY = Object.values(PLUGIN_TYPES)

src/runners/plugin.js

@@ -13,6 +13,7 @@ export const RUNNER_PLUGIN_TYPE = {
   // Name used:
   //  - As a default value for the selection property
   //  - As a default value for the configuration property appended with `Config`
+  //  - In the return value
   //  - In error messages
   name: 'runner',
   // Prefix of the npm package