Skip to content

Commit

Permalink
Rename variable
Browse files Browse the repository at this point in the history
  • Loading branch information
ehmicky committed Oct 3, 2021
1 parent 265010f commit a21629b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/combination/filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ const getCombinationDimensions = function ({ dimensions }) {
}

export const getCombNoDimensions = function (dimensionsArray) {
const propNames = Object.keys(dimensionsArray[0])
return propNames.filter((propName) =>
isNoDimensions(dimensionsArray, propName),
const dimensionNames = Object.keys(dimensionsArray[0])
return dimensionNames.filter((dimensionName) =>
isNoDimensions(dimensionsArray, dimensionName),
)
}

const isNoDimensions = function (dimensionsArray, propName) {
const ids = dimensionsArray.map((dimensions) => dimensions[propName].id)
const isNoDimensions = function (dimensionsArray, dimensionName) {
const ids = dimensionsArray.map((dimensions) => dimensions[dimensionName].id)
return [...new Set(ids)].length === 1
}

Expand Down

0 comments on commit a21629b

Please sign in to comment.