Skip to content

Commit

Permalink
Rename
Browse files Browse the repository at this point in the history
  • Loading branch information
ehmicky committed Sep 19, 2021
1 parent e9c2221 commit a5f0fdc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/combination/filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const omitCombNoDimensions = function (combination, noDimensions) {
// Like `listNoDimensions` but using combinations
export const getNoDimensions = function (combinations) {
const dimensionsArray = combinations.map(getCombinationDimensions)
return listNoDimensions(dimensionsArray)
return getCombNoDimensions(dimensionsArray)
}

const getCombinationDimensions = function ({ dimensions }) {
Expand All @@ -25,7 +25,7 @@ const getCombinationDimensions = function ({ dimensions }) {

// Retrieve `noDimensions`, i.e. dimensions that have the same ids across all
// combinations. Those are not reported, since they are redundant for users.
export const listNoDimensions = function (dimensionsArray) {
export const getCombNoDimensions = function (dimensionsArray) {
const propNames = Object.keys(dimensionsArray[0])
return propNames.filter((propName) =>
isNoDimensions(dimensionsArray, propName),
Expand Down
4 changes: 2 additions & 2 deletions src/combination/tasks/main.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { listNoDimensions } from '../filter.js'
import { getCombNoDimensions } from '../filter.js'

import { applyDefaultTasks } from './default.js'
import { findTasks } from './find.js'
Expand Down Expand Up @@ -81,7 +81,7 @@ import { loadRunner } from './load.js'
// - this does not work well with bundled runners
export const listTasks = async function (runners, cwd) {
const dimensionsArray = runners.map(getDimension)
const noDimensions = listNoDimensions(dimensionsArray)
const noDimensions = getCombNoDimensions(dimensionsArray)
const tasks = await Promise.all(
dimensionsArray.map((dimensions) => getDimensionsTasks(dimensions, cwd)),
)
Expand Down

0 comments on commit a5f0fdc

Please sign in to comment.