Skip to content

Commit

Permalink
Improve validation
Browse files Browse the repository at this point in the history
  • Loading branch information
ehmicky committed Mar 13, 2022
1 parent 080d690 commit c8dc7bc
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/config/normalize/lib/wild_wild_path/remove.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import { handleMissingValue } from './iterate/expand.js'
import { reduceParents, setValue } from './set.js'
import { validateClasses, reduceParents, setValue } from './set.js'

// Same as `set()` but removing a value
export const remove = function (
target,
query,
{ classes = false, mutate = false } = {},
) {
validateClasses(classes, mutate)
const setFunc = removeAnyEntry.bind(undefined, { classes, mutate })
return reduceParents({ target, query, setFunc, classes })
}
Expand Down
10 changes: 10 additions & 0 deletions src/config/normalize/lib/wild_wild_path/set.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,20 @@ export const set = function (
value,
{ classes = false, mutate = false } = {},
) {
validateClasses(classes, mutate)
const setFunc = setEntry.bind(undefined, { value, classes, mutate })
return reduceParents({ target, query, setFunc, classes })
}

// Class instances are not clonable. Therefore, they require `mutate`.
export const validateClasses = function (classes, mutate) {
if (classes && !mutate) {
throw new Error(
'The "mutate" option must be true when the "classes" option is true.',
)
}
}

// Modify a target object multiple times for each matched property.
export const reduceParents = function ({ target, query, setFunc, classes }) {
const entries = list(target, query, {
Expand Down

0 comments on commit c8dc7bc

Please sign in to comment.