Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ehmicky committed Sep 5, 2021
1 parent 496c6bd commit da877b9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/run/sample/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const measureSample = async function (
// This includes the duration to perform each step and doing IPC so that the
// actual sample duration does not deviate too much if one of those happened to
// be slow.
// We only keep the last `measureDuration` instead of taking the median of all
// We only keep the last `measureDuration` instead of taking the mean of all
// previous ones, so that `measureDuration` quickly adapts to machine slowdowns.
const measureNewSample = async function (payload, server) {
const measureDurationStart = now()
Expand Down
2 changes: 1 addition & 1 deletion src/run/sample/payload.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const getRepeatPayload = function (repeat, minLoopDuration) {
// computation and preview reporting
// - Due to the above point, the real sample duration is less close to the
// target.
// The value does not impact `stats.median` much though.
// The value does not impact `stats.mean` much though.
const getMaxLoops = function ({
repeat,
repeatLast,
Expand Down
2 changes: 1 addition & 1 deletion src/run/sample/repeat.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ const FAST_MEDIAN_RATE = 10
// - Excluding first samples except when there was not enough duration to
// measure more:
// - This rely on using a `duration` configuration property
// - This creates a big difference of stats (especially median and max)
// - This creates a big difference of stats (especially mean and max)
// depending on that duration
// - This can lead to comparing combinations with and without the cold start
// included in their stats
Expand Down

0 comments on commit da877b9

Please sign in to comment.