Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F4- clicked on imageview diff should jump to image #35

Closed
ehmkah opened this issue Oct 30, 2019 · 3 comments
Closed

F4- clicked on imageview diff should jump to image #35

ehmkah opened this issue Oct 30, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@ehmkah
Copy link
Owner

ehmkah commented Oct 30, 2019

Clicking F4 on imageDiff does not jump to image source.

Workaround: changeDiff Viewer to BinaryView , click f4
@ehmkah ehmkah added the bug Something isn't working label Oct 30, 2019
@ehmkah ehmkah changed the title F4- clicked on imageview diff should jkump to image F4- clicked on imageview diff should jump to image Oct 30, 2019
@ehmkah
Copy link
Owner Author

ehmkah commented Nov 4, 2019

Problem might be: class ImgDiffVirtualFile does not provide a useful path. Need to use path of real image-files

ehmkah added a commit that referenced this issue Nov 24, 2019
@ehmkah
fixed #35
9c847d6
@ehmkah ehmkah closed this as completed in 99acbeb Nov 24, 2019
@ehmkah
Copy link
Owner Author

ehmkah commented Nov 28, 2019 •
edited

Jump to source is working now, but shortcut f4 is missing. :-( Workaorund is now
"CTRL+ SHIFT+A" and enter' jump to source'

@ehmkah ehmkah reopened this Nov 28, 2019
ehmkah added a commit that referenced this issue Dec 13, 2019
@ehmkah
#35 fixed
7da1973
ehmkah added a commit that referenced this issue Dec 13, 2019
@ehmkah
#35 fixed
745c695
ehmkah added a commit that referenced this issue Dec 13, 2019
@ehmkah
35 fix (#42)
c204149 
* #35 fixed
@ehmkah
Copy link
Owner Author

ehmkah commented Dec 13, 2019

should now be fixed finally. :-)

@ehmkah ehmkah closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehmkah