Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is not functional in IntelliJ IDEA 2021.1 #66

Closed
forketyfork opened this issue Apr 12, 2021 · 7 comments
Closed

Plugin is not functional in IntelliJ IDEA 2021.1 #66

forketyfork opened this issue Apr 12, 2021 · 7 comments

Comments

@forketyfork
Copy link

forketyfork commented Apr 12, 2021

Describe the bug
Can't get the plugin to work in IntelliJ IDEA 2021.1. The diff window doesn't have any ImageDiff controls.

To Reproduce

  • Install the Image Diff plugin
  • Restart IDEA
  • Open the "Commit" panel (Alt+0), select a changed image and press Ctrl+D to view the diff.

Expected behavior
The diff window has the ImageDiff controls (dropdown, middle diff image)

Screenshots

diff

plugins

Desktop (please complete the following information):

Ubuntu Linux 20.04
IntelliJ IDEA 2021.1 (Ultimate Edition)
Build #IU-211.6693.111, built on April 6, 2021
ImageDiff plugin v1.9.0

@ehmkah
Copy link
Owner

ehmkah commented Apr 12, 2021

Thank you for your bug report. I can confirm that the plugin is not working with intellij 2021.1. At the moment I have no work-around but I will fix it.

@ehmkah
Copy link
Owner

ehmkah commented Apr 12, 2021

First investigation result. It seems that the "code with me" intellij plugin uses "my"-trick for changing the diff view behavior.

                        serviceImplementation="com.jetbrains.rdserver.vcs.BackendServerDiffManager"
                        overrides="true"/>

I do some research how to build around.

Unfortunately I found no way to remove the plugin because its bundled and can only be disabled.

@raDiesle
Copy link

same here. when disabling "code with me" it will work again

@ehmkah
Copy link
Owner

ehmkah commented Apr 13, 2021

@raDiesle - did it work after you disabled code-with-me? When I did it, the plugin still did not work.

@forketyfork
Copy link
Author

Disabling code-with-me worked for me.

@ehmkah
Copy link
Owner

ehmkah commented Apr 13, 2021

Made a bug-report for "code-with-me" https://youtrack.jetbrains.com/issue/CWM-2648

ehmkah added a commit that referenced this issue Apr 23, 2021
ehmkah added a commit that referenced this issue Apr 23, 2021
* #66 fixed

* run in intellij 2021.1
@ehmkah
Copy link
Owner

ehmkah commented Apr 23, 2021

Thanks to the wonderful Jetbrains-engineers. They helped me fixing this issue. The bugfix will be releases with version 1.10.0 which is on its way.

If you still have problems just reopen this issue and do not forget to enable "Code with me"-plugin. :-)

@ehmkah ehmkah closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants