Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

CBOR encoding clarifications #67

Merged
merged 7 commits into from
May 14, 2021
Merged

CBOR encoding clarifications #67

merged 7 commits into from
May 14, 2021

Conversation

jschlyter
Copy link
Contributor

Update main branch with CBOR encoding clarifications, no version changes.

Copy link
Contributor

@martin-lindstrom martin-lindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps include an example as well?

@kruzikh
Copy link
Contributor

kruzikh commented May 14, 2021

Guys I corrected the test type in json schema and added valueset for it. Please, could you check? We need to do it quickly as implementers are on a full speed!

@kruzikh kruzikh requested a review from SchulzeStTSI May 14, 2021 10:39
@jschlyter
Copy link
Contributor Author

@kruzikh looking good from my side, but this should bump the patchlevel version of the schema IMHO.

Next time, please make PR toward next for your specific change as the PRs next to main are for version management only.

@kruzikh
Copy link
Contributor

kruzikh commented May 14, 2021

Sorry, my mistake, I am still a begginer in git :-(

@gabywh
Copy link
Collaborator

gabywh commented May 14, 2021

Sorry, my mistake, I am still a begginer in git :-(

no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :(

Copy link
Collaborator

@gabywh gabywh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go :)

@gabywh
Copy link
Collaborator

gabywh commented May 14, 2021

but this should bump the patchlevel version of the schema IMHO.
@jschlyter feel free to bump, usual semver thing

@kruzikh
Copy link
Contributor

kruzikh commented May 14, 2021

Gaby, coul'd you propage correct json schema into the main ASAP?

@gabywh
Copy link
Collaborator

gabywh commented May 14, 2021

Gaby, coul'd you propage correct json schema into the main ASAP?

Yep, just waiting on one more reviewer to give the go ahead

@gabywh gabywh requested review from dirkx, fredriklj and gabywh May 14, 2021 12:30
gabywh
gabywh previously approved these changes May 14, 2021
ijansch
ijansch previously approved these changes May 14, 2021
dirkx
dirkx previously approved these changes May 14, 2021
@gabywh gabywh dismissed stale reviews from dirkx, ijansch, and themself via fd5028f May 14, 2021 12:54
@gabywh gabywh requested review from dirkx and kruzikh and removed request for fredriklj and SchulzeStTSI May 14, 2021 13:14
Copy link
Member

@dirkx dirkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - but this is getting a bit outsize my ken / expertise !

@jschlyter
Copy link
Contributor Author

no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :(

Actually, we are. We have main as our release/master branch and next as our develop branch. We've merged changes into next and once we're ready to release a set of new features as a release, we make a PR to main (and require at least 2 reviewers).

@gabywh
Copy link
Collaborator

gabywh commented May 14, 2021

no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :(

Actually, we are. We have main as our release/master branch and next as our develop branch. We've merged changes into next and once we're ready to release a set of new features as a release, we make a PR to main (and require at least 2 reviewers).

About the only standard thing we have here is main. We're not even doing upstream first with Next and release management also missing,. but whatever, I'm not going to start arguing about sw dev process, let's leave it at that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants