-
Notifications
You must be signed in to change notification settings - Fork 59
CBOR encoding clarifications #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps include an example as well?
Guys I corrected the test type in json schema and added valueset for it. Please, could you check? We need to do it quickly as implementers are on a full speed! |
@kruzikh looking good from my side, but this should bump the patchlevel version of the schema IMHO. Next time, please make PR toward next for your specific change as the PRs next to main are for version management only. |
Sorry, my mistake, I am still a begginer in git :-( |
no problem - actually even "Next" is not standard and should be deleted. There's a whole bunch of stuff around version management (as ever) including the original "gitflow" and derivatives "gitlab flow" and "github flow" and so on... Currently we're doing none of them here :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go :)
|
Gaby, coul'd you propage correct json schema into the main ASAP? |
Yep, just waiting on one more reviewer to give the go ahead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - but this is getting a bit outsize my ken / expertise !
Actually, we are. We have |
About the only standard thing we have here is main. We're not even doing upstream first with Next and release management also missing,. but whatever, I'm not going to start arguing about sw dev process, let's leave it at that. |
Update main branch with CBOR encoding clarifications, no version changes.