Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added glass NPSK53 #160

Merged
merged 2 commits into from Oct 18, 2022
Merged

added glass NPSK53 #160

merged 2 commits into from Oct 18, 2022

Conversation

syhaffert
Copy link
Collaborator

Added a single glass that was used in the LBTAO / MagAO-X pyramid prism for the wavefront sensor.

ehpor
ehpor previously approved these changes Oct 18, 2022
Copy link
Owner

@ehpor ehpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edit: well, I didn't see the whitespace. Fix that, and I'll reapprove.

@ehpor ehpor added the enhancement New feature or request label Oct 18, 2022
@ehpor ehpor added this to the v0.6.0 release milestone Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #160 (9fa36a9) into master (ffcb857) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files          95       95           
  Lines        6964     6964           
=======================================
  Hits         5634     5634           
  Misses       1330     1330           
Impacted Files Coverage Δ
hcipy/optics/glass.py 84.78% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@syhaffert
Copy link
Collaborator Author

just pushed the whitespace fix.

Copy link
Owner

@ehpor ehpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (now for real).

@ehpor ehpor merged commit b831ad1 into master Oct 18, 2022
@ehpor ehpor deleted the npsk53 branch October 18, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants