Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packaging to pyproject.toml. #179

Merged
merged 5 commits into from Apr 20, 2023
Merged

Upgrade packaging to pyproject.toml. #179

merged 5 commits into from Apr 20, 2023

Conversation

ehpor
Copy link
Owner

@ehpor ehpor commented Apr 8, 2023

Modern Python packages can contain a pyproject.toml file, first introduced in PEP 518 and later expanded in PEP 517, PEP 621 and PEP 660. This file contains build system requirements and information, which are used by pip to build the package.

As setup.py has been deprecated, we need to move to pyproject.toml packaging at some point. This PR accomplishes this. This also updates the documentation accordingly.

@ehpor ehpor added the maintenance Non-critical, but may become an issue in the future. label Apr 8, 2023
@ehpor ehpor self-assigned this Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #179 (e7b0313) into master (aa9cdb7) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   81.28%   81.24%   -0.05%     
==========================================
  Files          96       95       -1     
  Lines        7182     7175       -7     
==========================================
- Hits         5838     5829       -9     
- Misses       1344     1346       +2     
Impacted Files Coverage Δ
hcipy/__init__.py 96.00% <50.00%> (-4.00%) ⬇️
hcipy/util/io.py 86.51% <50.00%> (-0.92%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ehpor ehpor marked this pull request as ready for review April 9, 2023 00:37
@ehpor ehpor requested a review from syhaffert April 9, 2023 00:38
Re-remove codecov from requirements.
Copy link
Collaborator

@syhaffert syhaffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This can be merged.

@ehpor ehpor merged commit 06e0f5d into master Apr 20, 2023
16 checks passed
@ehpor ehpor deleted the feature/pyproject_toml branch April 20, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Non-critical, but may become an issue in the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants