Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wavelength argument from docstring. #222

Merged
merged 1 commit into from Jan 19, 2024

Conversation

ehpor
Copy link
Owner

@ehpor ehpor commented Jan 18, 2024

The API of the Fraunhofer propagator changed, but the docstring wasn't updated.

Fixes #221.

The API changed, but the docstring wasn't updated.
@ehpor ehpor requested a review from syhaffert January 18, 2024 21:58
@ehpor ehpor self-assigned this Jan 18, 2024
@ehpor ehpor added the documentation Missing or addition to documentation label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4f079a) 81.82% compared to head (b5f17c9) 81.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files          99       99           
  Lines        7355     7355           
=======================================
  Hits         6018     6018           
  Misses       1337     1337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehpor ehpor enabled auto-merge January 19, 2024 00:25
Copy link
Collaborator

@syhaffert syhaffert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging.

@ehpor ehpor merged commit 2d2b6de into master Jan 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Missing or addition to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docstring error in FraunhoferPropagator (?)
2 participants