Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change indentation from tabs to spaces (again). #224

Merged
merged 2 commits into from Mar 6, 2024

Conversation

ehpor
Copy link
Owner

@ehpor ehpor commented Mar 5, 2024

Fixing leftovers from #196. I do not know why a "replace-all" didn't catch all tabs, but there were quite a few leftovers.

Similar to before: an entry in the .git-blame-ignore-revs file allows Github to ignore the whitespace commit from all git-blame calls. This avoids cluttering up the git-blame view with just the blame from the first commit.

@ehpor ehpor added enhancement New feature or request maintenance Non-critical, but may become an issue in the future. labels Mar 5, 2024
@ehpor ehpor requested a review from ivalaginja March 5, 2024 23:07
@ehpor ehpor self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 76.31694% with 544 lines in your changes are missing coverage. Please review.

Project coverage is 82.05%. Comparing base (7aa6a85) to head (04cd8c9).

Files Patch % Lines
hcipy/field/util.py 63.09% 62 Missing ⚠️
hcipy/field/operations.py 73.02% 41 Missing ⚠️
hcipy/coronagraphy/apodizing_phase_plate.py 36.00% 32 Missing ⚠️
hcipy/field/grid.py 82.48% 31 Missing ⚠️
...ensing/optical_differentiation_wavefront_sensor.py 65.43% 28 Missing ⚠️
hcipy/wavefront_sensing/pyramid.py 70.52% 28 Missing ⚠️
hcipy/wavefront_sensing/wavefront_sensor.py 40.00% 27 Missing ⚠️
hcipy/coronagraphy/lyot.py 45.65% 25 Missing ⚠️
hcipy/wavefront_sensing/shack_hartmann.py 13.79% 25 Missing ⚠️
...cipy/wavefront_sensing/zernike_wavefront_sensor.py 61.90% 24 Missing ⚠️
... and 20 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         101      101           
  Lines        7552     7552           
=======================================
  Hits         6197     6197           
  Misses       1355     1355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all fine by me!

The backward transformation_matrix.
'''
return self.get_transformation_matrix_forward(wavelength)
r'''A perfect coronagraph for a certain aperture and order.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely unrelated to this PR, but is this r here on purpose? I found one more further below.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The r is for raw string, which escapes some of the math in this docstring.

zero = delta * (-dims / 2 + np.mod(dims, 2) * 0.5)

return CartesianGrid(RegularCoords(delta, dims, zero))
r'''Make a grid for a focal plane.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this r here in purpose?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The r is for raw string, which escapes some of the math in this docstring.

@ehpor ehpor merged commit 037b3b6 into master Mar 6, 2024
19 checks passed
@ehpor ehpor deleted the feature/whitespace_tabs_to_spaces_again branch March 6, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Non-critical, but may become an issue in the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants