Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/708 stored query versioning #1050

Merged
merged 14 commits into from
Feb 7, 2023
Merged

Feature/708 stored query versioning #1050

merged 14 commits into from
Feb 7, 2023

Conversation

HolgerReiseVSys
Copy link
Contributor

Changes

Improved versioning of stored queries

Related issue

Reference related issues, and use one of the closing keywords, e.g. closes or fixes to link the corresponding issue, if any.

Additional information

Provide additional information for this change, if needed.

Pre-Merge checklist

  • New code is tested
  • Present and new tests pass
  • Documentation is updated
  • The build is working without errors
  • No new Sonar issues introduced
  • Changelog is updated
  • Code has been reviewed

@HolgerReiseVSys HolgerReiseVSys marked this pull request as ready for review February 2, 2023 19:00
dmitrytulba
dmitrytulba approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@dmitrytulba dmitrytulba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

service/src/main/java/org/ehrbase/service/QueryServiceImp.java Show resolved Hide resolved
service/src/main/java/org/ehrbase/dao/access/jooq/StoredQueryAccess.java Outdated Show resolved Hide resolved
service/src/main/java/org/ehrbase/dao/access/jooq/StoredQueryAccess.java Outdated Show resolved Hide resolved
service/src/main/java/org/ehrbase/service/QueryServiceImp.java Show resolved Hide resolved
service/src/main/java/org/ehrbase/dao/access/util/StoredQueryQualifiedName.java Show resolved Hide resolved
service/src/main/java/org/ehrbase/dao/access/jooq/StoredQueryAccess.java Outdated Show resolved Hide resolved
service/src/main/java/org/ehrbase/dao/access/util/VersionConflictException.java Show resolved Hide resolved
service/src/main/java/org/ehrbase/dao/access/util/StoredQueryQualifiedName.java Outdated Show resolved Hide resolved
service/src/main/java/org/ehrbase/service/QueryServiceImp.java Show resolved Hide resolved
@HolgerReiseVSys HolgerReiseVSys force-pushed the feature/708_stored_query_versioning branch from d88d1f9 to e6b7054 Compare February 6, 2023 22:41
@HolgerReiseVSys HolgerReiseVSys force-pushed the feature/708_stored_query_versioning branch from c16547b to 49e942d Compare February 7, 2023 09:24
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.1% 64.1% Coverage
0.0% 0.0% Duplication

@HolgerReiseVSys HolgerReiseVSys merged commit 4dae040 into develop Feb 7, 2023
@HolgerReiseVSys HolgerReiseVSys deleted the feature/708_stored_query_versioning branch February 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrytulba dmitrytulba dmitrytulba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HolgerReiseVSys @dmitrytulba @vmueller-vg