Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save user in extra table #1067

Merged
merged 4 commits into from
Feb 28, 2023
Merged

save user in extra table #1067

merged 4 commits into from
Feb 28, 2023

Conversation

stefanspiska
Copy link
Contributor

No description provided.

@stefanspiska stefanspiska force-pushed the feature/CDR-741_concurrent_create_of_user branch from c2d8ca5 to b06e566 Compare February 28, 2023 13:20
@stefanspiska stefanspiska marked this pull request as ready for review February 28, 2023 13:22
HolgerReiseVSys
HolgerReiseVSys requested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@HolgerReiseVSys HolgerReiseVSys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions fpr cleanup & optimization

service/src/main/java/org/ehrbase/service/PartyServiceImp.java Outdated Show resolved Hide resolved
service/src/main/java/org/ehrbase/repository/PartyProxyRepository.java Outdated Show resolved Hide resolved
base/src/main/resources/db/migration/V81__save_user_extra_table.sql Show resolved Hide resolved
service/src/main/java/org/ehrbase/repository/PartyProxyRepository.java Outdated Show resolved Hide resolved
base/src/main/resources/db/migration/V81__save_user_extra_table.sql Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.2% 79.2% Coverage
0.0% 0.0% Duplication

@HolgerReiseVSys HolgerReiseVSys merged commit 8695215 into develop Feb 28, 2023
@HolgerReiseVSys HolgerReiseVSys deleted the feature/CDR-741_concurrent_create_of_user branch February 28, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HolgerReiseVSys HolgerReiseVSys HolgerReiseVSys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanspiska @HolgerReiseVSys