Feature/70 bug contribution delete composition #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes access layer handling of deleting a composition through a custom contribution. Now the custom contribution gets written into the DB by modifying the _history table entry. Together, a request with such a delete-contribution will get a response with the correct references of deleted compositions. Also includes little refatoring of access interfaces etc.
Further fixing of internal retrieval and handling of matching compositions to a given contribution. Also fixes a robot test and add smalls refactorings. Still needs new contribution change_type handling.
Adds handling of custom audit from contribution input. So client is responsible to commit correct kind of change type etc., which now gets processed and saved correctly.
…bug_contribution_delete_composition
jakesmolka
deleted the
feature/70_bug_contribution_delete_composition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes to allow deletion of a composition via committing a contribution.
In detail:
retrieveCompositionsInContribution())_historytable, but also creates new_historyentry documenting the deletion-version (seedeleteWithCustomContribution())commitContribution())Additionally, refactors
I_SimpleCRUDinterface to omit useless parameters.@testautomation can you take a quick look at the changes to the tests?
fixes ehrbase/project_management#70