[CDR-1329] Move CSRF config to an ehrbase.security.* property #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlehn
force-pushed
the
feature/CDR-1329-change-management-csrf-property
branch
from
23050d0
to
898b7c7
Compare
Robot Results
|
alexlehn
changed the title
HolgerReiseVSys
requested changes
May 2, 2024
| @@ -43,7 +44,7 @@ | |||
| * {@link Configuration} for secured endpoint authentication. | |||
| */ | |||
| @Configuration(proxyBeanMethods = false) | |||
| @EnableConfigurationProperties({SecurityProperties.class, SecuredWebEndpointProperties.class}) | |||
| @EnableConfigurationProperties({SecurityProperties.class, SecurityProperties.class}) | |||
There was a problem hiding this comment.
Duplication of SecurityProperties.class
...iguration/src/main/java/org/ehrbase/configuration/config/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
configuration/src/main/java/org/ehrbase/configuration/config/security/SecurityProperties.java
Outdated
Show resolved
Hide resolved
...iguration/src/main/java/org/ehrbase/configuration/config/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
|
HolgerReiseVSys
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change the management endpoint CSRF property location from
management.endpoints.web.csrf-validation-enabledtoehrbase.security.management.endpoints.web.csrf-validation-enabled.see #1294 (comment)
Pre-Merge checklist