Feature/134 bug ehr parameter #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to force boolean is_modifiable and is_queryable to have the default value 'true' despite boolean fields technically have default 'false'. Also defaults to 'true' on invalid input. ehrbase/project_management#134
ehrbase/project_management#134
ehrbase/project_management#134
stefanspiska
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/ehrbase/project_management/issues/134
Technical problem: Our deserialization was defaulting the boolean values to
false(Java spec) without any information left for the controller to see if this value wasfalseon purpose or not.Solution: Custom deserializer for EhrStatus, which
is_modifiableand sets it to the defaulttruevalue if necessary (vs. the Java defaultfalsefor booleans)is_queryableand sets it to the defaulttruevalue if necessaryfollowed by invoking the standard deserializer with the result input. So if the parameters were set to something valid in the request, everything is deserialized as before. But if not, the input is modified and routed into the normal deserialization.