Basic Auth support #200
Merged
Basic Auth support #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃敀 Basic Auth support from Spring Security and can be set via env 馃摑 Add documentation for Basic Auth configuration and usage via docker project_management#114
ehrbase/project_management#114
|
The integration test are all falling. please disable auth for Integration tests |
ehrbase/project_management#114
ehrbase/project_management#114
ehrbase/project_management#114
ehrbase/project_management#114
Reactivated Opt-In for test ehrbase/project_management#114
ehrbase/project_management#114
jakesmolka
reviewed
Mar 24, 2020
README.md
Outdated
| generate the Base64 encoded username and password combination create the string after the following schema: | ||
| `username:password`. | ||
|
|
||
| The Basic Auth mechanism is implemented as "opt-in" and can be deactivated by providing an environment variable |
There was a problem hiding this comment.
Typo? Shouldn't that be "opt-out"?
There was a problem hiding this comment.
Yes but I cannot get the Robot tests to run with authorization enabled and I cannot switch it off.
I need some advices from Wlad to get authorization working in the tests.
ehrbase/project_management#114
Disable request causing the failure due to not secure characters Change security to opt-out ehrbase/project_management#114
ehrbase/project_management#114
|
I was not able to successfully authenticate using the credentials. I used the examples provided in the readme and also checked with the security config (additionally set my own via environment variables). We might need to clarify if the problem is on my end. |
ehrbase/project_managemen#114
Remove environment variables usage for security Add yaml file configuration ehrbase/project_management#114
ehrbase/project_management#114
馃殌 Dockerfile uses new properties setting over env 馃摑 Update README.md to new environment settings ehrbase/project_management#114
birgerhaarbrandt
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敀 Basic Auth support from Spring Security and can be set via env
馃摑 Add documentation for Basic Auth configuration and usage via
docker
project_management#114
Changes
Related issue
Closes https://github.com/ehrbase/project_management/issues/114
Additional information and checks