Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate detection for directory #281

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

axelsiebert
Copy link
Contributor

@axelsiebert axelsiebert commented Jul 24, 2020

Changes

  • Add detection for already existing Directory of an EHR
  • Respond with 409 - CONFLICT in case of detected folder

Related issue

Fixes https://github.com/ehrbase/project_management/issues/231

Additional information and checks

  • Pull request linked in changelog

@axelsiebert axelsiebert changed the title [skip ci] Add duplicate detection for directory Add duplicate detection for directory Jul 24, 2020
Copy link
Contributor

@wlad wlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axelsiebert looks good. But seems we have no test that covers that case. We have a test that checks "validate POST response - 409 folder already exists" which is failing silently because it's marked as not-ready (it's related to https://github.com/ehrbase/project_management/issues/148)

I'm not sure if we need a new tests or have to refactor the existing one. We should should create a follow up ticket.

@axelsiebert
Copy link
Contributor Author

@axelsiebert looks good. But seems we have no test that covers that case. We have a test that checks "validate POST response - 409 folder already exists" which is failing silently because it's marked as not-ready (it's related to ehrbase/project_management#148)

I'm not sure if we need a new tests or have to refactor the existing one. We should should create a follow up ticket.

Sorry I made a mistake with the description of changes. The response code will be 409 as you mentioned. Then the test could be marked as ready.

@axelsiebert axelsiebert merged commit 7ad5caf into develop Jul 31, 2020
@wlad wlad deleted the feature/check_directory_duplicates branch September 7, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants