-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/447 get versioned ehr status #415
Conversation
@birgerhaarbrandt Who should review the integration test definition (see wiki link)? I just realized we don't have to wait with reviewing until the CI is fixed. |
also enhance 'wait for EHRbase' part in script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
- previously failing test now works locally and on CI
I committed some changes
- enhanced tests a little bit (cleaned up, removed some unnecessary lines)
- added a few more tests
- added bug trace to issue ehrbase/project_management/issues/458 (and marked related test as not-ready)
- fixed sometime failing EHRbase startup in CI script
@jakesmolka Check if the timezone converting in the integration tests will break if EHR timestamp gets correct format in the future. Edit: Timestamp handling in C.6 C) 3. looks alright. And the EHR timestamp response isn't used anymore, so there will be no problem with a change of format. 👍 |
@jakesmolka I have added my comments about the documentation here https://wiki.vitagroup.ag/pages/viewpage.action?spaceKey=ETHERCIS&title=Versioned+EHR_STATUS |
Kudos, SonarCloud Quality Gate passed! |
Changes
Related issue
closes https://github.com/ehrbase/project_management/issues/447
Additional information and checks