Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/413 versioned composition new #448

Merged
merged 19 commits into from
Mar 5, 2021
Merged

Feature/413 versioned composition new #448

merged 19 commits into from
Mar 5, 2021

Conversation

jakesmolka
Copy link
Contributor

@jakesmolka jakesmolka commented Feb 25, 2021 •
edited
Loading

WIP

  • Java side is done. But one bug which seems to be like https://github.com/ehrbase/project_management/issues/458 but only regarding composititons. Validate if that is the same problem or not. --> fixed for composition and status
  • The ITs are needing reviewing and alignment to existing test structure.
  • There is one "robot bug" in test C.6. which needs to be resolved

Changes

Related issue

fixes https://github.com/ehrbase/project_management/issues/413
fixes https://github.com/ehrbase/project_management/issues/458
resolves https://github.com/ehrbase/project_management/issues/17
resolves https://github.com/ehrbase/project_management/issues/122

Additional information and checks

  • Pull request linked in changelog

@jakesmolka jakesmolka requested a review from wlad February 25, 2021 10:23
jakesmolka and others added 5 commits March 1, 2021 15:21
@jakesmolka
Fixes contribution and audit bug
cce0a1b 
Compositions and status' weren't persisted correclty on update. Now each
update also create the necessary separate audit and contribution, if not
part of a larger contribution.
@jakesmolka
Fixes contribution object retrieval bug
5f2181a
@wlad
[UPDATE] composition test suite organisation and tags
5d94f6c 
[FIX] old tests
@wlad
[FIX] robot dot.dict issue and add some tags
4316ccd
@wlad
[REMOVE] bug trace to https://github.com/ehrbase/project_management/i…
0b96802 
…ssues/17
@wlad wlad marked this pull request as ready for review March 5, 2021 09:26
wlad
wlad approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@wlad wlad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

all tests pass locally and on CI
I've reorganized suite folders, fixed the dot.dict/string issue, fix some old tests and removed old bug traces

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

24.0% 24.0% Coverage
2.9% 2.9% Duplication

@jakesmolka jakesmolka merged commit 872b527 into develop Mar 5, 2021
@jakesmolka jakesmolka deleted the feature/413_versioned_composition_new branch March 5, 2021 11:29
@jakesmolka jakesmolka restored the feature/413_versioned_composition_new branch April 7, 2021 10:06
@wlad wlad deleted the feature/413_versioned_composition_new branch October 19, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlad wlad wlad approved these changes

Assignees

@jakesmolka jakesmolka

@wlad wlad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakesmolka @wlad