-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ehrscape compo uid #520
Conversation
One result from the failing tests is that it can't accept structures like this in folders anymore: "items": [
{
"id": {
"_type": "HIER_OBJECT_ID",
"value": "d936409e-901f-4994-8d33-ed104d460456"
},
"namespace": "my.system.id",
"type": "VERSIONED_COMPOSITION"
}
] The thrown error:
This particular case is invoked just by creating a folder. Code-wise this means the controller wants to map the input to an Archie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @jakesmolka and fixes what I commented for #552 (comment)
@jakesmolka from your comment and the error, it seems it comes from the Archie JSON parser, since the structure seems correct. Maybe, since OBJECT_REF has subclasses, the _type is needed there to be able to parse the correct type. |
@ppazos right! @subigre already fixed that in openEHR/archie#338 and therefore the bump in the last commit 🙂 |
Kudos, SonarCloud Quality Gate passed! |
Changes
Related issue
fixes #481
Additional information and checks