Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/436 folder audit #529

Merged
merged 9 commits into from
Jul 1, 2021
Merged

Feature/436 folder audit #529

merged 9 commits into from
Jul 1, 2021

Conversation

jakesmolka
Copy link
Contributor

@jakesmolka jakesmolka commented Jun 17, 2021

Changes

  • Adds commit_audit to folders
  • Fixes folder update
  • Fixes folder delete

Related issue

closes https://github.com/ehrbase/project_management/issues/436
closes https://github.com/ehrbase/project_management/issues/425

Additional information and checks

  • Pull request linked in changelog

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

80.4% 80.4% Coverage
6.1% 6.1% Duplication


@Override
public void setAudit(UUID auditId) {
this.getFolderRecord().setHasAudit(auditId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is tsrangly named

should be setAudit or setAuditUuid

@stefanspiska stefanspiska merged commit ed3c18c into develop Jul 1, 2021
@stefanspiska stefanspiska deleted the feature/436_folder_audit branch July 1, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants