Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/509 multiple accept header values #583

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Feature/509 multiple accept header values #583

merged 3 commits into from
Sep 9, 2021

Conversation

subigre
Copy link
Contributor

@subigre subigre commented Sep 8, 2021 •
edited
Loading

Changes

Fixes issue regarding Accept header with multiple MIME types.

Related issue

Resolves #509

Additional information and checks

  • Pull request linked in changelog

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.9% 64.9% Coverage
0.0% 0.0% Duplication

@subigre subigre marked this pull request as ready for review September 8, 2021 07:41
jakesmolka
jakesmolka approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@jakesmolka jakesmolka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And nice that you made small additional fixes to make everything a bit cleaner 👍

@subigre subigre merged commit f4ddac7 into develop Sep 9, 2021
@subigre subigre deleted the feature/509_multiple_accept_header_values branch September 9, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmolka jakesmolka jakesmolka approved these changes

Assignees

@jakesmolka jakesmolka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept Header - Multiple MIME types
2 participants
@subigre @jakesmolka