Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/project management/581 delete ehr large db #626

Merged
merged 9 commits into from
Oct 13, 2021

Conversation

subigre
Copy link
Contributor

@subigre subigre commented Oct 11, 2021

Changes

Refactor delete ehr using one plpgsql function

Related issue

Resolves ehrbase/project_management#581

Additional information and checks

  • Pull request linked in changelog

@subigre
Copy link
Contributor Author

subigre commented Oct 11, 2021

@chevalleyc, I think that all indexes are now created but the operation is still a bit long on very large DB.
I am wondering if we should not implement thies feature using batch and async processing?

@subigre subigre marked this pull request as ready for review October 11, 2021 12:50
@chevalleyc
Copy link
Contributor

@chevalleyc, I think that all indexes are now created but the operation is still a bit long on very large DB. I am wondering if we should not implement thies feature using batch and async processing?

I would agree with your comment. Specifically as deleting an EHR in a production environment is a heavy administrative procedure as it requires approvals and should be only use in the context of GDPR (right of erasure).

Copy link
Contributor

@chevalleyc chevalleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check the merge conflict

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@subigre subigre merged commit c7fc9c8 into develop Oct 13, 2021
@subigre subigre deleted the bugfix/project_management/581_delete_ehr_large_db branch October 13, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants