Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes CORS issue when security is enabled (#684) #697

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fixes CORS issue when security is enabled (#684) #697

merged 1 commit into from
Dec 13, 2021

Conversation

subigre
Copy link
Contributor

@subigre subigre commented Dec 10, 2021 •
edited
Loading

Changes

  • Fixes 401 when security is enabled.
  • Add custom configuration properties to configure CORS.

Related issue

Fixes #684

Additional information and checks

  • Pull request linked in changelog

@subigre subigre force-pushed the 619_cors_issue_security_nginx branch 2 times, most recently from 876e52e to 5190b46 Compare December 10, 2021 10:34
@subigre subigre marked this pull request as ready for review December 10, 2021 10:48
@subigre subigre force-pushed the 619_cors_issue_security_nginx branch from 5190b46 to 01515e5 Compare December 10, 2021 10:51
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.7% 37.7% Coverage
0.0% 0.0% Duplication

@stefanspiska stefanspiska merged commit eb106f2 into develop Dec 13, 2021
@stefanspiska stefanspiska deleted the 619_cors_issue_security_nginx branch December 13, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanspiska stefanspiska stefanspiska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS issue when security is enabled and using nginx proxy
2 participants
@subigre @stefanspiska