Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles expiry_time attribute #270

Merged
merged 4 commits into from Oct 20, 2021
Merged

Handles expiry_time attribute #270

merged 4 commits into from Oct 20, 2021

Conversation

subigre
Copy link
Contributor

@subigre subigre commented Oct 15, 2021

Process theexpiry_time attribute from INSTRUCTION

Fixes #269

@subigre
Handles expiry_time attribute
f41ab09
@subigre
Merge branch 'develop' into feature/269_missing_expiry_time
96b14c1 
# Conflicts:
#	serialisation/src/main/java/org/ehrbase/serialisation/dbencoding/CompositionSerializer.java
#	serialisation/src/test/java/org/ehrbase/serialisation/dbencoding/DBEncodeTest.java
@subigre
Updates CHANGELOG.md
6f88ab2
@subigre subigre marked this pull request as ready for review October 18, 2021 05:49
@chevalleyc
Copy link
Contributor

@subigre pls merge with #271 to get the tests going through.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@subigre subigre merged commit 340fff3 into develop Oct 20, 2021
@subigre subigre deleted the feature/269_missing_expiry_time branch October 20, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanspiska stefanspiska stefanspiska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing expiry_time from response
3 participants
@subigre @chevalleyc @stefanspiska