Feature/cdr 473 contains interpreter #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
see CDR-473
vmueller-vg
requested changes
Aug 8, 2022
There was a problem hiding this comment.
The noted issues are somewhat trivial.
The bigger issue is that the interpreter contains a whole lot of recursion, which makes the code harder to read/understand/debug. For the current goal of a prototype new engine this is fine, but i suspect there is some performance and readability/understandability to be gained by refactoring this later on.
aql/src/main/java/org/ehrbase/aql/dto/path/predicate/PredicateHelper.java
Show resolved
Hide resolved
...ata/src/main/java/org/ehrbase/test_data/operationaltemplate/OperationalTemplateTestData.java
Outdated
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/Interpreter.java
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/Interpreter.java
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/Interpreter.java
Outdated
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/Interpreter.java
Outdated
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/Interpreter.java
Outdated
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/InterpreterInput.java
Outdated
Show resolved
Hide resolved
web-template/src/main/java/org/ehrbase/webtemplate/interpreter/MatcherUtil.java
Show resolved
Hide resolved
web-template/src/test/java/org/ehrbase/webtemplate/interpreter/InterpreterTest.java
Show resolved
Hide resolved
|
Also please add an entry to CHANGELOG.md |
see CDR-473
see CDR-473
see CDR-473
see CDR-473
|
Kudos, SonarCloud Quality Gate passed! |
vmueller-vg
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.