Feature/cdt 186 add endpoint for execute stored aql queries #384
Conversation
…not included in the supported openEHR spec 1.0.0
| public QueryResponseData executeStoredQuery( | ||
| String qualifiedQueryName, | ||
| String version, | ||
| // Optional<UUID> ehrId, // TODO: ehr_id not available in openEHR 1.0.0 spec. Has to be included in | ||
| // queryParameter | ||
| Optional<Integer> offset, | ||
| Optional<Integer> fetch, | ||
| Optional<String> queryParameters) { |
There was a problem hiding this comment.
I would prefer to have a parameter object here.
There was a problem hiding this comment.
suggestion. use a dto with builder Patten. then in the its clear what is required and what is optional . and the returns can then return optinal for the optional values
There was a problem hiding this comment.
parameter object added
| String version, | ||
| // Optional<UUID> ehrId, // TODO: ehr_id not available in openEHR 1.0.0 spec. Has to be included in | ||
| // queryParameter | ||
| Optional<Integer> offset, |
There was a problem hiding this comment.
never use Optional as a parameter.
| @@ -159,6 +159,24 @@ protected HttpResponse internalPost( | |||
| return response; | |||
| } | |||
|
|
|||
| protected HttpResponse internalPut( | |||
There was a problem hiding this comment.
use this in httpPut line 184
There was a problem hiding this comment.
I would recommend to use interalPut from httpPut because the method httpPut is using more header which are currently not needed for the stored query PUT
|
Kudos, SonarCloud Quality Gate passed! |
done |
…stored_aql_queries
…stored_aql_queries
|
Kudos, SonarCloud Quality Gate passed! |
stefanspiska
deleted the
feature/CDT-186_add_endpoint_for_execute_stored_aql_queries
branch
added handling of stored AQL queries to the SDK