Feature/cdr 715 fix partial date time serialization #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmueller-vg
force-pushed
the
feature/CDR-715_fix-partial-date-time-serialization
branch
from
441938c
to
61743d8
Compare
|
Fixing this bug uncovered another bug, where the parser will accept partial dates with an invalid month like 2017-00 or 2017-13 instead of throwing an error. This is tested in COMPOSITION-tests-1 B.6.n which is the one that makes the pipeline fail |
…ialization # Conflicts: # serialisation/src/main/java/org/ehrbase/serialisation/jsonencoding/DateTimeSerializer.java
…x-partial-date-time-serialization # Conflicts: # CHANGELOG.md
dmitrytulba
reviewed
Mar 2, 2023
serialisation/src/main/java/org/ehrbase/serialisation/xmlencoding/CanonicalXML.java
Show resolved
Hide resolved
vmueller-vg
force-pushed
the
feature/CDR-715_fix-partial-date-time-serialization
branch
from
b5216e5
to
a808c92
Compare
…ialization # Conflicts: # CHANGELOG.md
…ialization # Conflicts: # bom/pom.xml
|
Kudos, SonarCloud Quality Gate passed! |
|
Note that 8 tests from COMPOSITION-tests-1 fail, because they compare error messages in addition to the status code. With the workaround implementation we now get more meaningful error messages that no longer match the ones expected by the tests. Affected test cases are: B.6.7.a |
stefanspiska
approved these changes
Mar 29, 2023
stefanspiska
deleted the
feature/CDR-715_fix-partial-date-time-serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.