Merge pull request #92 from eht16/fix_issue89_properly_close_socket

On closing UDP/TCP socket, make sure it is reset
eht16 · Feb 12, 2024 · 005e0bc · 005e0bc
2 parents e0961db + 96310f6
commit 005e0bc
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/logstash_async/transport.py b/logstash_async/transport.py
@@ -133,10 +133,12 @@ def _convert_data_to_send(self, data):
     def _close(self, force=False):
         if not self._keep_connection or force:
             if self._sock:
-                self._wait_for_socket_buffer_empty()
-                self._sock.shutdown(socket.SHUT_WR)
-                self._sock.close()
-                self._sock = None
+                try:
+                    self._wait_for_socket_buffer_empty()
+                    self._sock.shutdown(socket.SHUT_WR)
+                    self._sock.close()
+                finally:
+                    self._sock = None
 
     # ----------------------------------------------------------------------
     def _wait_for_socket_buffer_empty(self):