Skip to content

Commit

Permalink
* Fix ledgersmb#2835: adding/editing assemblies problems
Browse files Browse the repository at this point in the history
Kaare reports two problems:
1. The assembly add/edit page can't be updated without adding new parts
2. The Qty field in the BOM section of the page gets reset to 1

This commit fixes both of these problems (both reported in ledgersmb#2835).
  • Loading branch information
ehuelsmann committed Jun 14, 2017
1 parent 1abf7f4 commit ab42b0f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions Changelog
Expand Up @@ -10,6 +10,8 @@ Changelog for 1.5.8
* Fix 'On Hand' goods search filter not being applied (Erik H, #2845)
* Clean up issues found by Debian's 'lintian' (Erik H, Robert C)
* Fix layout regression of 1.5 in single payment screen (Erik H, #1917)
* Fix 'Update' on Assembly page resetting BOM count to 1 (Erik H, 2835)
* Fix 'Update' on Assembly page requiring all BOM lines filled (Erik H, 2835)

Erik H is Erik Huelsmann
Robert C is Robert James Clay
Expand Down
5 changes: 1 addition & 4 deletions bin/ic.pl
Expand Up @@ -1332,7 +1332,7 @@ sub assembly_row {
$column_data{qty} =
qq|<td><input data-dojo-type="dijit/form/TextBox" name="qty_$i" size=6 value="$form->{"qty_$i"}" accesskey="$i" title="[Alt-$i]"></td>|;
$column_data{partnumber} =
qq|<td><input data-dojo-type="lsmb/parts/PartSelector" name="partnumber_$i" size=15 value="$form->{"partnumber_$i"}" data-dojo-props="channel: '/part/part-select/$i'"></td>|;
qq|<td><input data-dojo-type="lsmb/parts/PartSelector" name="partnumber_$i" size=15 value="$form->{"partnumber_$i"}" data-dojo-props="required:false,channel: '/part/part-select/$i'"></td>|;
$column_data{description} =
qq|<td><div data-dojo-type="lsmb/parts/PartDescription" name="description_$i" size=30 data-dojo-props="channel: '/part/part-select/$i'">$form->{"description_$i"}</div></td>|;
$column_data{partsgroup} =
Expand Down Expand Up @@ -1469,9 +1469,6 @@ sub update {

if ($rows) {
$form->{"adj_$i"} = 1;

$form->{"qty_$i"} = 1;
$form->{"adj_$i"} = 1;
for (qw(partnumber description unit)) {
$form->{item_list}[$i]{$_} =
$form->quote( $form->{item_list}[$i]{$_} );
Expand Down

0 comments on commit ab42b0f

Please sign in to comment.