chrome was not honoring pre-selected tags. fixes #46

ehynds · Dec 17, 2010 · de5dc55 · de5dc55
1 parent 3fd9286
commit de5dc55
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/demos/single.htm b/demos/single.htm
@@ -49,7 +49,7 @@ <h2>Single Select</h2>
 
 <form>
 	<p>
-		<select name="demo" multiple="multiple" size="5">
+		<select name="demo">
 		<option value="option1">Option 1</option>
 		<option value="option2">Option 2</option>
 		<option value="option3">Option 3</option>

diff --git a/src/jquery.multiselect.js b/src/jquery.multiselect.js
@@ -128,7 +128,7 @@ $.widget("ech.multiselect", {
 				$parent = $this.parent(), 
 				isDisabled = $this.is(':disabled'), 
 				labelClasses = ['ui-corner-all'],
-				label, input, checkbox, li;
+				label, input, li;
 
 			// is this an optgroup?
 			if( $parent.is('optgroup') ){
@@ -158,9 +158,9 @@ $.widget("ech.multiselect", {
 					.addClass(labelClasses.join(' '))
 					.appendTo( li );
 
-				// attr's are inlined to support form reset
-				checkbox = $('<input type="'+(o.multiple ? 'checkbox' : 'radio')+'" '+($this.is(':selected') ? 'checked="checked"' : '')+ '" name="multiselect_'+id + '" />')
-					.attr({ id:inputID, title:title, disabled:isDisabled, 'aria-disabled':isDisabled })
+				// attr's are inlined to support form reset.  double checked attr is to support chrome bug - see #46
+				$('<input type="'+(o.multiple ? 'checkbox' : 'radio')+'" '+(this.selected ? 'checked="checked"' : '')+ ' name="multiselect_'+id + '" />')
+					.attr({ id:inputID, checked:this.selected, title:title, disabled:isDisabled, 'aria-disabled':isDisabled, 'aria-selected':this.selected })
 					.val( value )
 					.appendTo( label )
 					.after('<span>'+title+'</span>');