Re-implement groupColumnsWidth #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one mostly passes the unit test. The new unit test for width has one issue with a difference in width, not sure if that is a problem with the test though.
|
All the tests pass for me on this PR, including the new width one that I had added before which you said is failing. What browser are you using to run the tests? I've run into similar issues before where the tests behave slightly differently across different browsers and operating systems so I'd like to be able to reproduce it on my machine and make the test more resilient. |
|
Sorry for the delay. The browser was Firefox, and it is now working on the first pass. Thanks for getting this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one mostly passes the unit test. The new unit test for width has one issue with a difference in width, not sure if that is a problem with the test though.
What changes are you proposing? Why are they needed?
Allows the specification of the column width for columnGroups and allows columnGroups to be used for the generalized multiselect.
Related Issue numbers
Closes #854
Pull Request Approval Checklist: