eicrecon-init.sh not correctly configured in Docker on Mac

[kkauder]

Environment: (where does this bug occur, have you tried other environments)

• Which branch (often main for latest released): main
• Which version (or HEAD for the most recent on git): HEAD
• Any specific OS or system where the issue occurs? In Docker+Mac, can't replicate in singularity, can't test docker/linux
• Any special versions of ROOT or Geant4? No

Steps to reproduce: (give a step by step account of how to trigger the bug)

source /opt/detector/setup.sh
git clone git@github.com:eic/drich-dev.git
cd drich-dev
git clone git@github.com:eic/EICrecon.git
mv EICrecon eicrecon # sigh...
source environ.sh
./build eicrecon 
## Take a lunch break, compilation is slow with Rosetta2
source prefix/bin/eicrecon-this.sh

Expected Result: (what do you expect when you execute the steps above)

No output / correct execution

Actual Result: (what do you get when you execute the steps above)

ERROR: must "cd where/root/is" before calling ". bin/thisroot.sh" for this version of "qemu-x86_64"!
ERROR: must "cd where/root/is" before calling ". bin/thisroot.sh" for this version of "qemu-x86_64"!

Proposed Fix: #1111 (review)

[wdconinc]

thisroot.sh seems to detect your shell as qemu-x86_64. Please report to ROOT. We can apply the fix to ROOT that they suggest.

[wdconinc]

I'll try to run the inverse qemu emulation to see if I can reproduce, but don't get your hopes up :-)

[wdconinc]

The only other issue in ROOT that refers to qemu was reported by me :-\ and it's different.

[wdconinc]

Can reproduce on linux, docker, qemu within docker run --rm -it --platform linux/arm64 ghcr.io/eic/jug_dev:master-nightly.

ROOT uses cut -d '' -f1 /proc/$$/cmdline to determine the shell, which gets you the qemu binfmt interpreter, both in your case qemu-x86_64 (with some prefix path that get chopped later) and in my case /usr/libexec/qemu-binfmt/aarch64-binfmt-P (same thing really). If ROOT could use field 2 cut -d '' -f2 /proc/$$/cmdline it would find the correct shell and then it would just source thisroot.sh fine (of course, that wouldn't work without qemu).

[wdconinc]

~~For the upstream ROOT bug report, you can probably use the docker image rootproject/root:6.28.04-fedora37 (which is arm64). https://hub.docker.com/r/rootproject/root/tags ~~

Edit: Nevermind, that image is a conda install which doesn't install thisroot.sh.

[kkauder]

That was a hell of a deep delve. Should I close the PR? While fixing it in root (which can take time) is better, my patch shouldn't hurt. That said, the bug itself probably only, if at all, manifests if you change root installations, be it inside eic-shell or outside AND in a weird shell. The outside part is hardest to predict off-hand, and it's unlikely to be a scenario for eic-recon often in the near future, but it's a consideration for jana2 maybe.

[wdconinc]

Keep the PR open; it's the appropriate workaround now that we have identified what the cause it. We can merge it when you have submitted the issue to ROOT, and we'll keep track of that issue in EICrecon so we can back out the workaround again once a ROOT fix is available.

[wdconinc]

@kkauder Can you post the link you the ROOT issue please?

[kkauder]

@wdconinc root-project/root#14085

[wdconinc]

Fixed by #1111