refactor: replace RawPMTHit with RawTrackerHit
#508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
c-dilks
changed the title
RawPMTHit with RawTrackerHitRawPMTHit with RawTrackerHit
c-dilks
force-pushed
the
RawPMTHit_to_RawTrackerHit
branch
from
d8b091c
to
5dd5491
Compare
|
CI failures are unrelated to this PR (and currently happening on |
|
Why is it segfaulting now? Just noticed in main too ... |
wdconinc
previously approved these changes
Mar 3, 2023
|
Set to auto-merge, pending unresolved conversation. |
|
I also applied these changes to the Juggler MR |
wdconinc
approved these changes
Mar 3, 2023
|
Same exact CI failures are happening on unrelated PR #524, so it seems like this is a general problem. |
|
Oddly enough, the last push to |
|
Can you restart a job on main? Might be due to jana upgrade... |
|
Sure, re-running the last PR merge commit: https://github.com/eic/EICrecon/actions/runs/4320254537 (which passed all CI checks before this) |
|
Same failures |
|
And it's one of those 'fun' failures that doesn't fail inside valgrind... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
edm4eic::RawPMTHitis basically a duplicatedatatypeofedm4eic::RawTrackerHit, so let's useRawTrackerHitand deprecateRawPMTHit.See also eic/EDM4eic#22
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No (except in #393)
Does this PR change default behavior?
No