Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding LFHCal benchmarks in benchmarks/forward_lfhcal #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

steinber
Copy link

Briefly, what does this PR introduce?

I'm working through Dima's tutorial (yes a few weeks behind...)

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [X ] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No breaking changes - just first steps toward a benchmark (fingers crossed)

Does this PR change default behavior?

None - just setting up the benchmark framework

@veprbl
Copy link
Member

veprbl commented Feb 13, 2024

Strangely, "push" trigger didn't react to your branch. I'm not sure why. I've triggered manually via "workflow_dispatch" for now. Here is the eicweb pipeline:

https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/pipelines/82259

@veprbl
Copy link
Member

veprbl commented Feb 14, 2024

For the current most up to date benchmark, I'd look at the barrel ecal one:
https://github.com/eic/detector_benchmarks/tree/master/benchmarks/barrel_ecal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants